Skip to content

TYP: __array__ #30839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2020
Merged

TYP: __array__ #30839

merged 1 commit into from
Jan 9, 2020

Conversation

jbrockmendel
Copy link
Member

No description provided.

WillAyd
WillAyd requested changes Jan 9, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add Dtype from pandas._typing to these? I think should be pretty trivial to add while touching

@jbrockmendel
Copy link
Member Author

Can you add Dtype from pandas._typing to these? I think should be pretty trivial to add while touching

I think we would need something more restricted to rule out ExtensionDtype

WillAyd
WillAyd approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @simonjayhawkins

@WillAyd WillAyd added the Typing type annotations, mypy/pyright type checking label Jan 9, 2020
@simonjayhawkins simonjayhawkins added this to the 1.0 milestone Jan 9, 2020
@TomAugspurger TomAugspurger merged commit 0dc317f into pandas-dev:master Jan 9, 2020
@TomAugspurger
Copy link
Contributor

Thanks!

@jbrockmendel jbrockmendel deleted the typ-__array__ branch January 9, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jbrockmendel @TomAugspurger @WillAyd @simonjayhawkins